Skip to content

New v8 Changes #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Sep 3, 2015
Merged

New v8 Changes #169

merged 25 commits into from
Sep 3, 2015

Conversation

@deankarn
Copy link
Contributor

@deankarn deankarn commented Sep 3, 2015

Additions

  • Add alias logic. now can add an alias to validations using function RegisterAliasValidation. i.e. "iscolor" is alias for "hexcolor|rgb|rgba|hsl|hsla"

Changes

  • dereference BakedInValidators, no need to pass in anymore, should use registration function to add more.
  • add tag validation to ensure it does not overwrite core tags necessary to library operation and invalid characters.
  • core changes of how and where caching is implemented.

joeybloggs and others added 25 commits August 29, 2015 23:07
Add Tag Alias + basic tests
2cda50f 
so far so good
Update Alias logic
407aac4 
- Unexport Alias Map in order to preserve any custom user aliases that
  may conflict with new aliases added to the library itself....need to
  copy them for each new validator.
- update error to report alias tag as the error tag and add actualTag to
  know what it would have actually been.
Completed 100% test coverage for alis registration
a964f53
Add alias docs + notes
b4563c2
Add Alias to the unique features section of README
b213226
updated tag caching for maximum performance
c293315
unexpose baked in validators map for safety.
4807bf9
update New to use register functions to avoid errors
9988ba3
reorganization of code + variables to more appropriate structs
10cf645
update how config is passed in and assigned to validator
70cb087 
* makes it safer as options passed in by reference, in the future, will
  not be manipulatable externally.
Update Error Pool
0b51279 
* made error pool per validator instance to reduce contention is
  multiple validators are in play.
update comments
9990e05
update more comments
b2d8b41
Update README for v8
19b2f07
Add validation error info to DOC
d792c5a
Add Error handling info to README
22a5f70
@flowonyx
Added checking for nil receiver on Validator methods
715aa55
Merge pull request #166 from flowonyx/v7-development
0650f73 
Added checking for nil receiver on Validator methods
Update Validator instance check
14df416 
* change for one validator instance method and message
Merge pull request #167 from joeybloggs/v7-development
e66bd70 
Update Validator instance check
Merge branch 'v7-development' into merge
e8133a0
update to v8 benchmarks
b366564
add more docs to doc.go
9e4314f
inline Regex calls
8119861
update benchmarks
aa72515
@deankarn deankarn self-assigned this Sep 3, 2015
@deankarn deankarn added this to the v8 milestone Sep 3, 2015
deankarn pushed a commit that referenced this pull request Sep 3, 2015
Merge pull request #169 from joeybloggs/v8-development
40bd6a0 
New v8 Changes
@deankarn deankarn merged commit 40bd6a0 into go-playground:v8-development Sep 3, 2015
fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
@fairyhunter13
Merge pull request go-playground#169 from joeybloggs/v8-development
35c03d0 
New v8 Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@deankarn deankarn

Labels

enhancement new

Projects

None yet

Milestone

v8

Development

Successfully merging this pull request may close these issues.

2 participants

@deankarn @flowonyx