Skip to content

Conversation

@tulir
Copy link
Contributor

@tulir tulir commented Oct 1, 2017

Confidential issues have the same payload as normal issues, but they have a separate hook type. This pull request adds support for the Confidential Issue Hook event type.

tulir added a commit to maubot/gitlab that referenced this pull request Oct 1, 2017
@deankarn
Copy link
Collaborator

deankarn commented Oct 1, 2017

Thanks @tulir

I would prefer to do it a slightly different way so that the end user can distinguish between Issues and confidential issues when the payload comes through by:

  • having a separate confidential payload type (can embed the issue type) and just in case they types ever diverge it's easy to separate them without making breaking changes.

@deankarn deankarn merged commit 5462959 into go-playground:v3 Oct 2, 2017
@tulir tulir deleted the patch-2 branch October 2, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants