Skip to content

Remove unnecessary adapter type casting #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Remove unnecessary adapter type casting #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions postgres_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func dsn() string {
func TestAdapter_specs(t *testing.T) {
adapter, err := Open(dsn())
assert.Nil(t, err)
defer adapter.(*Postgres).Close()
defer adapter.Close()

repo := rel.New(adapter)

Expand Down Expand Up @@ -104,23 +104,23 @@ func TestAdapter_specs(t *testing.T) {
func TestAdapter_Transaction_commitError(t *testing.T) {
adapter, err := Open(dsn())
assert.Nil(t, err)
defer adapter.(*Postgres).Close()
defer adapter.Close()

assert.NotNil(t, adapter.Commit(ctx))
}

func TestAdapter_Transaction_rollbackError(t *testing.T) {
adapter, err := Open(dsn())
assert.Nil(t, err)
defer adapter.(*Postgres).Close()
defer adapter.Close()

assert.NotNil(t, adapter.Rollback(ctx))
}

func TestAdapter_Exec_error(t *testing.T) {
adapter, err := Open(dsn())
assert.Nil(t, err)
defer adapter.(*Postgres).Close()
defer adapter.Close()

_, _, err = adapter.Exec(ctx, "error", nil)
assert.NotNil(t, err)
Expand Down