Use HTTP Client SetTimeout instead of custom timeout #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 96.48% 96.48% -0.01%
==========================================
Files 9 11 +2
Lines 883 882 -1
==========================================
- Hits 852 851 -1
Misses 17 17
Partials 14 14
Continue to review full report at Codecov.
|
jeevatkm
changed the title
jeevatkm
reviewed
Mar 10, 2017
Member
jeevatkm
left a comment
jeevatkm
left a comment
There was a problem hiding this comment.
I have a look on your changes, I appreciate your time and contribution.
Please have a look on my review comment.
client.go
Outdated
| // SetTimeout method sets timeout for request raised from client | ||
| // resty.SetTimeout(time.Duration(1 * time.Minute)) | ||
| // | ||
| func (c *Client) SetTimeout(timeout time.Duration) *Client { |
Member
There was a problem hiding this comment.
Currently resty support Go1.2 and above. HTTP Client SetTimeout was introduced in Go1.3. You see travis build is failed for Go1.2
Can you please handle these support with build constraints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(#59) by using
http.Client.Timeoutinstead of a specialhttp.Transport.