Skip to content

Conversation

@chebizarro
Copy link
Contributor

One of the errors detected by fuzzing (#53, #384) was the creation of valid geometries from corrupt data. This patch goes some ways to remedying this by checking if the BOM is correctly set (0 or 1) as per the specification and returning an error if it is any other value.

@chebizarro chebizarro requested review from ARolek and gdey as code owners April 6, 2018 19:29
@coveralls
Copy link

coveralls commented Apr 6, 2018

Pull Request Test Coverage Report for Build 979

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 46.31%

Files with Coverage Reduction New Missed Lines %
provider/gpkg/binary_header.go 2 100.0%
Totals Coverage Status
Change from base Build 977: 0.0%
Covered Lines: 5824
Relevant Lines: 12576

💛 - Coveralls

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdey gdey merged commit e45838b into go-spatial:v0.7.0 Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants