is rollback necessary if the connection drops?

[bbigras]

Issue description

I have a many (20+) INSERT in multiples tables (4-5) in the same transaction. If an error happens, some data is still INSERTED, no rollback.

I have autocommit=0 in my MySQL URL (not sure if it's 0 by default).

I'm assuming that the transaction should fail and all the data discarded if there's an error and the connection drops.

Am I wrong?

Example code

I'm not able to reproduce it with a small sample yet.

Error log

Configuration

Driver version (or git SHA): ae5a66d

Go version: go version go1.8.1 linux/amd64

Server version: E.g. MySQL 5.7.18 (using the official MySQL docker image)

Server OS: Arch Linux 64-bit

[methane]

You should use explicit transaction. https://golang.org/pkg/database/sql/#DB.Begin

[bbigras]

Yes I'm using Begin() to create my transaction. I got an error before Commit() is called and data is still inserted in the database. It's weird.

[methane]

I think you are doing something wrong.
Without reproducible example, I can't believe you.

[methane]

https://dev.mysql.com/doc/refman/5.7/en/cannot-roll-back.html
This is one of common pitfall.
But I don't know this bites you or not. Because no example.

Issues without concrete info is not report, just a noise.

[bbigras]

Thanks.