Skip to content

release v1.10.0#1765

Merged
methane merged 2 commits intogo-sql-driver:masterfrom
methane:release-1101
Apr 29, 2026
Merged

release v1.10.0#1765
methane merged 2 commits intogo-sql-driver:masterfrom
methane:release-1101

Conversation

@methane
Copy link
Copy Markdown
Member

@methane methane commented Apr 28, 2026

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3732a378-dc40-457d-a6d9-5739fc8d85b5

📥 Commits

Reviewing files that changed from the base of the PR and between d730c02 and 0e2ceb3.

📒 Files selected for processing (1)
  • CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

Walkthrough

Adds release notes for v1.10.0 and v1.9.3 to CHANGELOG.md documenting bug fixes, behavior changes, a dependency bump, and supported Go versions update.

Changes

Cohort / File(s) Summary
Changelog Updates
CHANGELOG.md
Added release notes for v1.10.0 (fix for getSystemVar("max_allowed_packet") when maxAllowedPacket=0, upgrade filippo.io/edwards25519 1.1.1→1.2.0, Go support changed to 1.24–1.26, interpolateParams no longer treats ? inside strings/comments as placeholders) and v1.9.3 (tx.Commit/tx.Rollback error handling fix, small result-set compression read optimization, db.Ping() fix for compressed connections).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • release v1.9.0 #1662 — Another changelog-only update in the same repository documenting release notes.

Suggested reviewers

  • shogo82148
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains a release checklist that is generic and not specifically descriptive of the changeset, using non-descriptive items that don't convey meaningful information about what was actually changed in CHANGELOG.md. Add specific details about the release notes being added for v1.10.0 and v1.9.3, including key fixes and changes documented in the CHANGELOG.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'release v1.10.0' is concise and clearly identifies the primary change - a release version update, which aligns with the CHANGELOG.md updates documenting v1.10.0 and v1.9.3 release notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
CHANGELOG.md (1)

3-15: Changelog heading style is inconsistent (“v1.x” vs “Version 1.x”).

This file otherwise uses ## Version ... formatting for older releases (e.g., later in the file), but v1.10.0 uses ## v1.10.0. Consider normalizing for readability and consistency.

🛠️ Proposed formatting tweak
-## v1.10.0 (2026-04-28)
+## Version 1.10.0 (2026-04-28)
...
-## v1.9.3 (2025-06-13)
+## Version 1.9.3 (2025-06-13)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` around lines 3 - 15, Change the inconsistent changelog heading
"## v1.10.0 (2026-04-28)" to match the existing style used elsewhere (e.g., "##
Version 1.10.0 (2026-04-28)"); update that heading text in CHANGELOG.md so it
follows the "Version X.Y.Z" pattern and scan nearby entries to ensure the same
formatting convention is used consistently throughout the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGELOG.md`:
- Around line 22-24: Update the v1.9.3 changelog bullet text that currently
reads "* Optimize reading small resultsets to fix performance regression
introduced by compression protocol support. (`#1707`)" to be a single,
well-punctuated sentence and use "result sets" instead of "resultsets"; ensure
the sentence ends with a period before the citation and the entire bullet is on
one line for consistency with other entries in CHANGELOG.md.

---

Nitpick comments:
In `@CHANGELOG.md`:
- Around line 3-15: Change the inconsistent changelog heading "## v1.10.0
(2026-04-28)" to match the existing style used elsewhere (e.g., "## Version
1.10.0 (2026-04-28)"); update that heading text in CHANGELOG.md so it follows
the "Version X.Y.Z" pattern and scan nearby entries to ensure the same
formatting convention is used consistently throughout the file.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: eee2cc5b-53fe-411f-9846-a5b83612ed5e

📥 Commits

Reviewing files that changed from the base of the PR and between 09e4187 and d730c02.

📒 Files selected for processing (1)
  • CHANGELOG.md

Comment thread CHANGELOG.md Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 28, 2026

Coverage Status

coverage: 82.701%. remained the same — methane:release-1101 into go-sql-driver:master

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@methane methane merged commit a065b60 into go-sql-driver:master Apr 29, 2026
38 checks passed
@methane methane deleted the release-1101 branch April 29, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants