ci(release): switch homebrew install to formula#14
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the release and documentation flow to distribute tapd via a Homebrew formula instead of a cask, aligning installation with typical CLI conventions and avoiding Gatekeeper warnings associated with cask-downloaded binaries.
Changes:
- Switch GoReleaser from
homebrew_caskstobrewsand publish the formula intoFormula/. - Define formula install/test stanzas (
bin.install "tapd"and a basic--helptest). - Update README Homebrew install instructions to use formula install syntax.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
README.md |
Updates the Homebrew install command to use formula syntax (no --cask). |
.goreleaser.yaml |
Replaces cask publishing with formula publishing and adds Homebrew install/test stanzas for the released binary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request transitions the Homebrew distribution from a Cask to a Formula by updating the .goreleaser.yaml configuration and the installation instructions in README.md. The reviewer suggested enhancing the Homebrew test block to verify that the command output contains expected content, ensuring the binary functions correctly rather than just checking the exit status.
| test: | | ||
| system "#{bin}/tapd", "--help" |
There was a problem hiding this comment.
The Homebrew test block currently only verifies that the command exits successfully. It is a best practice to also verify that the output contains expected content (e.g., the application name) to ensure the binary is functioning correctly and is the intended tool.
test: |
assert_match "tapd", shell_output("#{bin}/tapd --help")
Summary
Switch the Homebrew distribution from cask install syntax to a formula-based install path for the tapd CLI.
Changes
Motivation
Testing