Skip to content

ci(release): switch homebrew install to formula#14

Merged
flc1125 merged 3 commits into
mainfrom
release/homebrew-formula
May 19, 2026
Merged

ci(release): switch homebrew install to formula#14
flc1125 merged 3 commits into
mainfrom
release/homebrew-formula

Conversation

@flc1125
Copy link
Copy Markdown
Member

@flc1125 flc1125 commented May 19, 2026

Summary

Switch the Homebrew distribution from cask install syntax to a formula-based install path for the tapd CLI.

Changes

  • Replace the GoReleaser Homebrew cask publisher with a formula publisher under Formula/tapd.rb
  • Install the released tapd binary through the formula bin.install stanza
  • Update the README install command to brew install go-tapd/tap/tapd

Motivation

  • tapd is a CLI, so formula install syntax is more natural than cask syntax
  • This avoids directing CLI users through the cask flow that triggered macOS Gatekeeper warnings for downloaded binaries

Testing

  • make release-check
  • make release-snapshot
  • go test ./...
  • brew info --formula go-tapd/tap/tapd against the generated formula

Copilot AI review requested due to automatic review settings May 19, 2026 15:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@flc1125 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 46 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0a96d672-c7a5-4f9c-b068-5eaa54b9adac

📥 Commits

Reviewing files that changed from the base of the PR and between 7b263a4 and 929ac31.

📒 Files selected for processing (2)
  • .goreleaser.yaml
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/homebrew-formula

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release and documentation flow to distribute tapd via a Homebrew formula instead of a cask, aligning installation with typical CLI conventions and avoiding Gatekeeper warnings associated with cask-downloaded binaries.

Changes:

  • Switch GoReleaser from homebrew_casks to brews and publish the formula into Formula/.
  • Define formula install/test stanzas (bin.install "tapd" and a basic --help test).
  • Update README Homebrew install instructions to use formula install syntax.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
README.md Updates the Homebrew install command to use formula syntax (no --cask).
.goreleaser.yaml Replaces cask publishing with formula publishing and adds Homebrew install/test stanzas for the released binary.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@flc1125 flc1125 merged commit 754a352 into main May 19, 2026
3 checks passed
@flc1125 flc1125 deleted the release/homebrew-formula branch May 19, 2026 15:48
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the Homebrew distribution from a Cask to a Formula by updating the .goreleaser.yaml configuration and the installation instructions in README.md. The reviewer suggested enhancing the Homebrew test block to verify that the command output contains expected content, ensuring the binary functions correctly rather than just checking the exit status.

Comment thread .goreleaser.yaml
Comment on lines +61 to +62
test: |
system "#{bin}/tapd", "--help"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Homebrew test block currently only verifies that the command exits successfully. It is a best practice to also verify that the output contains expected content (e.g., the application name) to ensure the binary is functioning correctly and is the intended tool.

    test: |
      assert_match "tapd", shell_output("#{bin}/tapd --help")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants