perf(templater): skip template engine for strings without {{

[romnn]

First commit from #2819 with comments removed. Speeds up task --list from 13.8 seconds to ~5 seconds on a large monorepo. See original PR for details.

• I have read and followed the Contribution Guide

[trulede]

LGTM.

If you like to experiment further, AI suggests this at the start of the function.

func ReplaceWithExtra[T any](v T, cache *Cache, extra map[string]any) T {
	if cache.err != nil {
		return v
	}

	// Optimization: Direct check for common simple types
	// If it's a string and doesn't have "{{", return immediately.
	if s, ok := any(v).(string); ok {
		if !strings.Contains(s, "{{") {
			return v
		}
	}

[romnn]

Great suggestion, this indeed saved another 1.5 to 2 seconds on our repo!

I've folded it into my single commit as per the contributing guide and decided to add a very concise comment in both places to highlight that those short circuits are purely performance optimizations and not behavioral. I think those are stylistically fine and improve clarity, but I can also adjust or remove them.

[trulede]

Great suggestion, this indeed saved another 1.5 to 2 seconds on our repo!

That is a great outcome! The PR is fine.

[andreynering]

Very simple, yet we never thought about doing this optimization 🙂

Thank you!