[shaping] better face selection for mixed RTL/LTR with marks#245
Merged
benoitkugler merged 1 commit intomainfrom Mar 27, 2026
Merged
[shaping] better face selection for mixed RTL/LTR with marks#245benoitkugler merged 1 commit intomainfrom
benoitkugler merged 1 commit intomainfrom
Conversation
whereswaldon
approved these changes
Mar 27, 2026
Member
whereswaldon
left a comment
whereswaldon
left a comment
There was a problem hiding this comment.
Thank you! This is a tricky case indeed.
3ace
pushed a commit
to unidoc/typesetting
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shaping the string
\u200fabc, out segmentation process produces two runs (Input) with correct direction and script, but with different fonts. This is suboptimal : we should not change font for runes such as \u200f (a RTL mark).This issue is that our font selection function only works one
Inputat a time, whereas a "cross" run analysis is required here.This PR aims at fixing this issue, by back propagating the selected font to previous
Inputs.This is a minor change which should not impact the majority of use cases.