fix(kubernetes): Coordinate Runtime's RunContainer/TailContainer via a channel#286
Closed
cognifloyd wants to merge 1 commit intogo-vela:masterfrom
Closed
fix(kubernetes): Coordinate Runtime's RunContainer/TailContainer via a channel#286cognifloyd wants to merge 1 commit intogo-vela:masterfrom
cognifloyd wants to merge 1 commit intogo-vela:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 78.91% 78.13% -0.78%
==========================================
Files 67 67
Lines 4870 4954 +84
==========================================
+ Hits 3843 3871 +28
- Misses 884 944 +60
+ Partials 143 139 -4
|
4bb4b83 to
0b94b85
Compare
The Kubernetes runtime needs to start streaming logs before the container starts. The Docker runtime needs to start the container before streaming longs. With both running in goroutines, the Runtime can block one method until the other completes in whichever order makes sense for that Runtime.
0b94b85 to
b91cf19
Compare
6 tasks
Member
Author
|
Closing in favor of #303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes runtime needs to start streaming logs before the container starts.
The Docker runtime needs to start the container before streaming longs.
With both running in goroutines, the Runtime can block one method until the other completes in whichever order makes sense for that Runtime.
Alternate to #277