Skip to content

fix: replace deprecated reflect.Ptr with reflect.Pointer#38

Merged
kolkov merged 1 commit intomainfrom
fix/lint-reflect-ptr
May 6, 2026
Merged

fix: replace deprecated reflect.Ptr with reflect.Pointer#38
kolkov merged 1 commit intomainfrom
fix/lint-reflect-ptr

Conversation

@kolkov
Copy link
Copy Markdown
Contributor

@kolkov kolkov commented May 6, 2026

Summary

  • Replace 4 occurrences of reflect.Ptr with reflect.Pointer in ffi/callback.go
  • reflect.Ptr deprecated since Go 1.18, golangci-lint v2.12.1 now flags it via govet inline checker

Context

CI lint failure blocking PR #37. This is pre-existing tech debt, not related to #37's changes.

Test plan

  • Lint passes (the only change is constant rename, semantically identical)
  • Build passes
  • Tests pass

reflect.Ptr was deprecated in Go 1.18 in favor of reflect.Pointer.
golangci-lint v2.12.1 now flags this via govet inline checker.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ffi/callback.go 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@kolkov kolkov merged commit 3fa3b83 into main May 6, 2026
10 checks passed
@kolkov kolkov deleted the fix/lint-reflect-ptr branch May 6, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant