Added function to get PD offset by address in control panel#290
Closed
hahnnicholas wants to merge 2 commits intogoToMain:masterfrom
Closed
Added function to get PD offset by address in control panel#290hahnnicholas wants to merge 2 commits intogoToMain:masterfrom
hahnnicholas wants to merge 2 commits intogoToMain:masterfrom
Conversation
Member
|
Hi @hahnnicholas , thanks for the PR and the effort it involved. But I think the application code is much cleaner place to do this (it already knows pd_info array offsets and the address for each PD in it). For instance, in the python library, I do exactly that -- maintain a map of PD offset and PD address. |
Member
|
I did cherry-pick your format string patch downstream. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple lookup function.
This change allows using some CP functions without first having the index of each PD which might be required after add pds on the fly.