Skip to content

Comments

rac: prevent SSH connections from connecting to wrong endpoint#13589

Closed
dominic-r wants to merge 2 commits intogoauthentik:mainfrom
dominic-r:sdko/rac-session-fixes
Closed

rac: prevent SSH connections from connecting to wrong endpoint#13589
dominic-r wants to merge 2 commits intogoauthentik:mainfrom
dominic-r:sdko/rac-session-fixes

Conversation

@dominic-r
Copy link
Member

@dominic-r dominic-r commented Mar 20, 2025

When using multiple SSH RAC endpoints, connections would sometimes connect to previously used endpoints instead of the newly selected one.

Closes #13609
Closes #13583

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@dominic-r dominic-r requested a review from a team as a code owner March 20, 2025 03:40
@netlify
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 462a04f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/680e634b24f04700073e8a9c

@netlify
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 462a04f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/680e634bf60d550008f100ce

@dominic-r dominic-r force-pushed the sdko/rac-session-fixes branch from a0a8a0e to 01d4722 Compare March 20, 2025 03:44
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (3c6b8b1) to head (462a04f).
Report is 152 commits behind head on main.

Files with missing lines Patch % Lines
authentik/providers/rac/views.py 28.57% 5 Missing ⚠️
authentik/providers/rac/consumer_client.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13589      +/-   ##
==========================================
- Coverage   92.71%   92.70%   -0.02%     
==========================================
  Files         809      809              
  Lines       41533    41538       +5     
==========================================
  Hits        38506    38506              
- Misses       3027     3032       +5     
Flag Coverage Δ
e2e 47.77% <0.00%> (-0.01%) ⬇️
integration 24.39% <0.00%> (-0.01%) ⬇️
unit 90.56% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dominic-r dominic-r marked this pull request as draft March 20, 2025 05:06
@crazy-kol
Copy link

So this will fix that issue?

@dominic-r
Copy link
Member Author

So this will fix that issue?

yes

@crazy-kol
Copy link

So this will fix that issue?

yes

How do I download this update and deploy it on my server?

@dominic-r
Copy link
Member Author

I wouldn't suggest doing this for now as this is still in the development phase and may contain bugs.

@dominic-r
Copy link
Member Author

It should be included in hopefully 2025.4

@crazy-kol
Copy link

It should be included in hopefully 2025.4

And how long till that?

@dominic-r dominic-r force-pushed the sdko/rac-session-fixes branch from a951835 to 2ae7250 Compare March 24, 2025 01:15
@crazy-kol
Copy link

Is there a way to use this before the actual release?

@dominic-r
Copy link
Member Author

It should be included in hopefully 2025.4

And how long till that?

Probably mid to end april

@crazy-kol
Copy link

It should be included in hopefully 2025.4

And how long till that?

Probably mid to end april

Is there a way to use this before the actual release?

@dominic-r
Copy link
Member Author

dominic-r commented Mar 24, 2025

Is there a way to use this before the actual release?

You can follow a rebase process similar to #13463 (comment) and build a custom docker container to then deploy on your k8s cluster for example. Do note that since this is still a draft and has not been reviewed by the other members of the team, you may encounter issues. If you do, please LMK and I'll do my best to resolve them

@crazy-kol
Copy link

Is there a way to use this before the actual release?

You can follow a rebase process similar to #13463 (comment) and build a custom docker container to then deploy on your k8s cluster for example. Do note that since this is still a draft and has not been reviewed by the other members of the team, you may encounter issues. If you do, please LMK and I'll do my best to resolve them

Is there any way that we could talk on discord and you could help me do this?

@dominic-r
Copy link
Member Author

Sure, my user is 4d62. I'm on the authentik Discord

@dominic-r dominic-r force-pushed the sdko/rac-session-fixes branch from 28418ba to 67829d9 Compare March 24, 2025 01:57
@dominic-r dominic-r marked this pull request as ready for review March 24, 2025 02:09
@dominic-r dominic-r marked this pull request as draft March 26, 2025 21:47
@lightumcc
Copy link

Any updates on this PR? Can’t wait to apply this fix

@dominic-r dominic-r force-pushed the sdko/rac-session-fixes branch from 0e722df to 7d39de9 Compare April 27, 2025 16:53
@dominic-r dominic-r closed this May 13, 2025
@dominic-r dominic-r deleted the sdko/rac-session-fixes branch May 13, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RAC Choose Wrong Connection SSH Connection loop

3 participants