infinoted: Sync directory creation does not obey umask

[pkern]

infinoted-util.c's infinoted_util_create_dirname contains this for directory creation:

result = inf_file_util_create_directory(dirname, 0700, error);

infinoted_plugin_directory_sync_save uses this helper function to create these directory and embeds another instance:

if(inf_file_util_create_directory(plugin->directory, 0700, error) == FALSE)

Both codepaths do not obey any umask and make the directories unconditionally unreadable to anyone else than the daemon user. This makes it difficult to serve the sync output from a web server running under a different uid. g_file_set_contents does the right thing so the problem does not affect written out files, just directories.

[aburgm]

So all that needs to be changed would be using mode 0755 instead of 0700? The umask is then applied automatically by mkdir().

[pkern]

I wonder if that'd mean 0777 and let the umask be subtracted to be fully controllable by the user.

[aburgm]

Good point. I have changed it to 0777.

[pkern]

I verified that the fix works. Thanks!