ci: single Go 1.26 toolchain via mise#2
Merged
Merged
Conversation
Signed-off-by: Richard Case <richard.case@outlook.com>
The .golangci.yml on master uses the v2 config schema, which v1.61 cannot parse. Bump golangci-lint to 2.12.2 (built with Go 1.26) and fix the issues v2 surfaces: - Refactor mos6502.Disassemble: extract addressing-mode operand emission into appendOperand + small mode helpers, dropping cyclomatic complexity below the gocyclo threshold. - Silence goconst on the opcodes.go dispatch table — repeated mnemonic strings are table data, not duplicated logic. - Rename unused parameters in golden_trace_test.go scaffolds to _. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Richard Case <richard.case@outlook.com>
richardcase
force-pushed
the
ci-go126-mise
branch
from
486675f to
fd59352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.22.x,1.26.x) — test only Go 1.26.go.modtogo 1.26..mise.tomlpinninggo = "1.26"andgolangci-lint = "1.61.0"for reproducible local dev.jdx/mise-action@v2instead ofactions/setup-go+golangci/golangci-lint-action.Test plan
mise installlocally pulls Go 1.26 + golangci-lint 1.61.0.make fmt vet lint testpasses with mise-installed toolchain.Note: branch off
master. Depends on feature branch001-cpu-6502-corelanding first (introducesgo.modand originalci.yml); diff here shows them as new files.