Improve memOutOfBounds precision for points-to sets which mix allocs with others#2030
Draft
sim642 wants to merge 2 commits into
Draft
Improve memOutOfBounds precision for points-to sets which mix allocs with others#2030sim642 wants to merge 2 commits into
sim642 wants to merge 2 commits into
Conversation
Pointer may point to either allocated blob or static array. Currently memOutOfBounds only uses BlobSize query for points-to sets which are definitely alloc, but not a mix.
Member
Author
|
According to an sv-benchmarks run with level01, 60s and 1GB, this doesn't improve any verdicts: https://goblint.cs.ut.ee/results/335-all-level01-pr-2030-after/table-generator-cmp.diff.html#/table. However, there is a regression on
where Somehow it's coming from the |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #2029.
Pointer may point to either allocated blob or static array.
Currently memOutOfBounds only uses
BlobSizequery for points-to sets which are definitely alloc, but not a mix.This moves the decision to be made per-pointee basis, not on the basis of the whole points-to set.
The diff probably looks much nicer with whitespace ignored.
TODO
TopValueexceptions from sv-benchmarks.