Merged
Conversation
Member
Author
|
It fails on windows tests since "make not found". |
Member
|
Try to rebase from master. I believe it was fixed there a couple of days ago.
…On Nov 20, 2018, 9:46 PM -0500, Yonghwan SO ***@***.***>, wrote:
It fails on windows tests since "make not found".
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
Author
|
Yes, I found the update and pushed merged version already. (since I faced it does not run checks when I just rebased, so I just merge with master.) |
markbates
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
httptest.Requestcreateshttp.Requestby callinghttp.NewRequestdirectly, it does not preserve second parameterurlasRequest.RequestURI, the unmodified request-target. As a result, if a user's application uses something likecontext.Request().RequestURI, the app works fine withRequestURIbut testing with httptest will failed since there is noRequestURIon the structure.This PR just added the value manually to present
RequestURIas the user expected.