Merged
Conversation
lawrencejones
force-pushed
the
lawrence-vendor-deps
branch
from
a6b67e1 to
ada3651
Compare
Contributor
Author
|
Rebased and pruned the deps. Should be good now! |
hmac
reviewed
Dec 12, 2017
| Install [dep](https://github.com/golang/dep) | ||
| ``` | ||
| brew install dep | ||
| ``` |
Contributor
There was a problem hiding this comment.
Let's keep this - you still need it to add or update dependencies.
hmac
suggested changes
Dec 13, 2017
| - checkout | ||
| - run: mkdir -p $TEST_RESULTS | ||
| - run: go get github.com/golang/dep/cmd/dep | ||
| - run: dep ensure -vendor-only |
Contributor
There was a problem hiding this comment.
Sorry, I keep thinking of things each time I look at this PR - can we run “dep something” here to check that our vendored deps match what’s in the lockfile? So we catch if someone has edited them manually or something.
Check that the vendor directory is up-to-date and is valid as part of our test runs.
Contributor
Author
|
@hmac prod! |
hmac
approved these changes
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That.