Merged
Conversation
hmac
reviewed
Feb 5, 2018
| func(error) { serverInsecure.Shutdown(context.Background()) }, | ||
| ) | ||
|
|
||
| if err := g.Run(); err != nil { |
Contributor
There was a problem hiding this comment.
Might as well use the logger here, instead of log
hmac
reviewed
Feb 5, 2018
| if err != nil { | ||
|
|
||
| // We then listen for insecure connections on localhost, allowing draupnir-client to be | ||
| // used locally on the draupnir box to administrate the server. |
Contributor
There was a problem hiding this comment.
Could be more generic here - , allowing connections from within the host
hmac
approved these changes
Feb 5, 2018
It would be really useful for draupnir to listen on HTTP for connections from the same box. This enables usage of the draupnir-client locally, pointing at localhost for the connection, without having issues with certificates.
lawrencejones
force-pushed
the
lawrence-listen-locally-insecure
branch
from
afd2abf to
30688e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be really useful for draupnir to listen on HTTP for connections
from the same box. This enables usage of the draupnir-client locally,
pointing at localhost for the connection, without having issues with
certificates.