Merged
Conversation
Instead of manually shoving things into the request context, violating the abstraction of the logging and auth middlewares, use the fakes we already have for this purpose.
hmac
force-pushed
the
hmac/test-cleanup
branch
2 times, most recently
from
c07951d to
183a8a9
Compare
lawrencejones
approved these changes
Apr 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this makes these tests a little bit nicer. Somewhat sad that we're exactly even on line count, but you can't always win!
Also includes a change to bump the required Ruby version to 2.5.0