Switch from WEBrick to Puma #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschafer-gc
force-pushed
the
tschafer-switch-from-webrick-to-puma-2
branch
from
76b2159 to
fc91cd0
Compare
tschafer-gc
force-pushed
the
tschafer-switch-from-webrick-to-puma-2
branch
from
fc91cd0 to
22b8a03
Compare
benk-gc
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEBrick appears to be approaching EOL and is being removed from Rackup, as mentioned here. This is causing issues with a number of services as discussed here. By switching to Puma we can solve this issue while also still supporting both Rack 2 and 3.
I merged this change in a previous PR, but then had to revert it due to issues in pay-svc. This PR adds a fix (the second commit) to pass in
pidfile: nilto Puma iftmp/pids/doesn't exist. I'll test this out on Skyhook and Pay-svc for a few days to get confidence it works okay.