Skip to content

Stop skipping matching of request bodies#4

Merged
jackfranklin merged 1 commit into
masterfrom
matching-request-bodies
May 21, 2015
Merged

Stop skipping matching of request bodies#4
jackfranklin merged 1 commit into
masterfrom
matching-request-bodies

Conversation

@jackfranklin
Copy link
Copy Markdown
Contributor

  • if a stub doesn't specify data, but the request has it, just match as true anyway (so you don't have to define data of every POST request)
  • remove the skipping of data matching if the stub is being validated

@harrison can you please review?

Comment thread spec/stubby.spec.js
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change, just a typo I spotted

@jackfranklin jackfranklin force-pushed the matching-request-bodies branch from 21e8e32 to 5d2f310 Compare May 21, 2015 10:33
@feelepxyz
Copy link
Copy Markdown
Contributor

👍

jackfranklin added a commit that referenced this pull request May 21, 2015
Stop skipping matching of request bodies
@jackfranklin jackfranklin merged commit bc12e78 into master May 21, 2015
@jackfranklin jackfranklin deleted the matching-request-bodies branch May 21, 2015 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants