Allow a new stub to override a match if one exists by passing param#5
Merged
Conversation
There was a problem hiding this comment.
could you just check !_.isEmpty here?
|
👍 |
jackfranklin
force-pushed
the
allow-override-with-param
branch
2 times, most recently
from
f39f94e to
eff84d8
Compare
jackfranklin
added a commit
that referenced
this pull request
Jun 1, 2015
Allow a new stub to override a match if one exists by passing param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maxmurdoch please could you review?
This is useful functionality when we have something that we stub globally in E2E (eg
/users) and in a particular test want to stub it with something else. Doingstub.remove({})and thenstub({})is kind of annoying.It's useful to have Stubby blow up by default if you try to stub something that already exists but I see no harm in allowing a param to be passed.