deps: upgrade goceleris/loadgen to v1.0.0#239
Merged
FumingPower3925 merged 2 commits intomainfrom Mar 29, 2026
Merged
Conversation
Breaking API migration: - Config: WarmupTime→Warmup, H2C→HTTP2, KeepAlive→DisableKeepAlive, H2Connections/H2MaxStreams→HTTP2Options struct - New() returns (*Benchmarker, error) — add error handling - Checkpoint types moved to loadgen/checkpoint subpackage - result.ToServerResult() → checkpoint.NewServerResult() - internal/bench imports replaced with loadgen + loadgen/checkpoint
FumingPower3925
force-pushed
the
deps/loadgen-v1.0.0
branch
from
e31181c to
ceebf5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
goceleris/loadgenfrom pre-release (v0.0.0-20260329011655-20c034d132d2) tov1.0.0.Breaking API Changes Applied
WarmupTime→Warmup,H2C→HTTP2,KeepAlive→DisableKeepAlive(inverted),H2Connections/H2MaxStreams→HTTP2OptionsstructNew()returns error: Added error handling at all 3 call sites (runner.go local, runner.go retry, cmd/loadgen)Checkpoint,BenchmarkOutput,BenchmarkConfig,ServerResult,LatencyResult,SystemMetrics,GCPauseStats) moved fromloadgentoloadgen/checkpointToServerResult:result.ToServerResult(...)→checkpoint.NewServerResult(result, ...)TimeseriesPoint: Stays in rootloadgenpackage (no change)Files Changed (8)
cmd/bench/runner.go— Config renames, New() error handling, checkpoint importscmd/bench/config.go— checkpoint imports, renamed local var to avoid shadowingcmd/bench/c2client.go— checkpoint.ServerResult importcmd/loadgen/main.go— Config renames, New() error handlinginternal/dashboard/format.go— checkpoint importsinternal/dashboard/format_test.go— checkpoint importsgo.mod/go.sum— loadgen v1.0.0Test plan
go build ./...— cleango vet ./...— cleango test ./internal/dashboard/— passes