Support more options with context#27
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 297 320 +23
=========================================
+ Hits 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new job option to derive a per-run (per-attempt) context.Context from the job’s base context and current Task, enabling more flexible context scoping around Run executions.
Changes:
- Introduced
DeriveContextandWithDeriveContextto let callers customize the context used byRun. - Stored the new option on
innerJoband applied it inside the retry loop before callingsafeRun.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| job_option.go | Adds DeriveContext type + WithDeriveContext option to configure per-run context derivation. |
| inner_job.go | Threads the derived context into safeRun for each retry attempt. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
78
to
+82
| ctx, cancel := context.WithDeadline(context.WithValue(parentCtx, keyContextTask, task), nextAt) | ||
| defer cancel() | ||
|
|
||
| if j.before != nil && j.before(task) { | ||
| task.Skipped = true | ||
| atomic.AddInt64(&j.statistics.SkippedTask, 1) | ||
| if j.deriveContext != nil { | ||
| ctx = j.deriveContext(ctx, task) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.