Issue-2077 refactor gallery carousel to use tiny-swiper instead of flickity#2147
Merged
Conversation
Contributor
Contributor
snovosel
added
the
[Status] Do Not Merge
Contributor
Contributor
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FailuresThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Contributor
Contributor
Contributor
Contributor
| width: 62px; | ||
| } | ||
|
|
||
| &__next { |
Contributor
There was a problem hiding this comment.
You should group left and right styles that are shared.
&__prev,
&__next {
border: none;
padding: 15px;
...
}
&__prev {
left: 0;
}
&__next {
right: 0;
}
Contributor
Contributor
…cks into issue-2077-merge
Contributor
Contributor
Contributor
|
Download coblocks.zip: https://37002-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2147.zip |
Contributor
Contributor
Contributor
Contributor
|
Looks great to me! A small difference that I see is that in the Editor side, there is no arrows on the side to switch from one image to another one. If that's an intended change, I don't see any other problem with it :) |
Contributor
Contributor
olafleur-godaddy
approved these changes
Dec 6, 2021
Contributor
olafleur-godaddy
left a comment
olafleur-godaddy
left a comment
There was a problem hiding this comment.
Looks good to me if you want to merge!
snovosel
requested review from
AnthonyLedesma,
EvanHerman,
jonathanbardo and
jrtashjian
as code owners
snovosel
removed
the
[Status] Do Not Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refactor the Gallery Carousel block to implement the tiny-swiper package as opposed to Flickity. this removes jQuery as a dependency of this block.
Screenshots
Types of changes
code refactor
How has this been tested?
Checklist: