Merged
Conversation
Author
|
Gif of the updated vertical rhythm in action: |
richtabor
added
[Priority] High
richtabor
added
[Status] Needs Review
EvanHerman
approved these changes
Feb 13, 2020
Contributor
EvanHerman
left a comment
EvanHerman
left a comment
There was a problem hiding this comment.
Nice, works well on my end 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a first pass at an improved vertical rhythm system. The goal here is to adapt the vertical rhythm to not be so large on wide monitors (due to the nature of
vmunits).I'm essentially capping out the
--vertical-rhythm--lrgonhugeviewports. The downside to this approach is that it's not very portable if we were to bring the vertical rhythm into an editable UI (unless we did some sort of auto-conversion to figure out what the max rem should be).Design Styles:
If this work, it will close #429