Optimize partition ID validation and eliminate redundant string length calls#147
Merged
jgowdy-godaddy merged 1 commit intomainfrom Mar 4, 2026
Merged
Optimize partition ID validation and eliminate redundant string length calls#147jgowdy-godaddy merged 1 commit intomainfrom
jgowdy-godaddy merged 1 commit intomainfrom
Conversation
…h calls - Add RequireParameterStringWithLength to get string and UTF-8 length in one N-API call - Add optional utf8_length parameter to CobhanBufferNapi constructor and StringToAllocationSize - Pass pre-calculated partition_id_length through all encrypt/decrypt code paths - Add empty partition ID validation with clear error messages - Add 4 tests for empty partition ID rejection (encrypt/decrypt × sync/async)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequireParameterStringWithLengthto get string and UTF-8 length in a single N-API callutf8_lengthparameter toCobhanBufferNapiconstructor andStringToAllocationSizeto avoid redundantGetUtf8StringLengthcalls when length is already knownpartition_id_lengththrough all encrypt/decrypt code paths (sync/async, stack/heap)Test plan