[fix] resolver of react-native loops require on ./#13
Merged
indexzero merged 3 commits intogodaddy:masterfrom Sep 27, 2017
Merged
[fix] resolver of react-native loops require on ./#13indexzero merged 3 commits intogodaddy:masterfrom
indexzero merged 3 commits intogodaddy:masterfrom
Conversation
3rd-Eden
approved these changes
Sep 27, 2017
3rd-Eden
approved these changes
Sep 27, 2017
indexzero
approved these changes
Sep 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/godaddy/breakdancer/pull/13/files#diff-61319e4d886068e46127c00a303ff649L1 is the main change. Decided to create base
Breakdancerclass and specify web or native logic in separate files respectively