Skip to content

fix(interactivity): harden missing-arg prompt formatting - #110

Merged
jpage-godaddy merged 3 commits into
mainfrom
fix/prompt-formatting
Sep 2, 2026
Merged

fix(interactivity): harden missing-arg prompt formatting#110
jpage-godaddy merged 3 commits into
mainfrom
fix/prompt-formatting

Conversation

@rts1-godaddy

Copy link
Copy Markdown
Collaborator

Summary

  • Fix interactive recovery prompts for clap 4.6 missing-arg identifiers such as --tld <TLD> and <QUERY> (regression from PR fix(interactivity): Prompt formatting #106 where strip_arg_decoration mangled flag <VALUE> pairs into tld <TLD)
  • Parse required ArgGroup errors (<--a <a>|--b <b>>, <--one|--two>) with a select prompt and correct flag/value append logic
  • Avoid double colons when help text already ends with :, and add unit tests covering real clap error shapes

Test plan

  • cargo test -p cli-engine prompt::tests
  • cargo test --all-targets

Made with Cursor

rts1-godaddy and others added 3 commits September 1, 2026 13:53
* Added new parsing helpers
* Updated format_prompt_message
* Fixed missing argument recovery flow
Handle clap 4.6 flag/value identifiers, required ArgGroups, and help text
that already ends with a colon so interactive recovery shows clear prompts.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jpage-godaddy
jpage-godaddy merged commit ac1c011 into main Sep 2, 2026
2 checks passed
@jpage-godaddy
jpage-godaddy deleted the fix/prompt-formatting branch September 2, 2026 21:49
@github-actions github-actions Bot mentioned this pull request Sep 2, 2026
jpage-godaddy pushed a commit that referenced this pull request Sep 3, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>cli-engine: 0.9.4</summary>

##
[0.9.4](cli-engine-v0.9.3...cli-engine-v0.9.4)
(2026-09-02)


### Features

* **auth:** support scope hierarchies for OAuth step-up decisions
([#111](#111))
([d33956b](d33956b))


### Bug Fixes

* **interactivity:** harden missing-arg prompt formatting
([#110](#110))
([ac1c011](ac1c011))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants