[DEVEX-708] fix(application validate): restore remote application state checks#134
Merged
Merged
Conversation
jpearlman-godaddy
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores gddy application validate <name> to validate remote application state (fetching the application by name) rather than only validating local godaddy.toml, aligning behavior with the TypeScript CLI and returning a structured { valid, errors, warnings } result.
Changes:
- Updates
application validateto require an application name, fetch remote application data, and report validation errors/warnings based on remote fields (url,proxyUrl,status). - Updates help/long descriptions and “next actions” to reference
application validate <name>and remote validation semantics. - Adds unit tests for clap argument requirements and for the remote validation rules.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ), | ||
| ) | ||
| .with_param("application-id", required_value(app_id)) | ||
| .with_param("version", required_value("0.0.1")), |
Collaborator
There was a problem hiding this comment.
Isn't 0.0.1 just an example? Let's leave version unspecified.
jpage-godaddy
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application validate <name>to fetch and check remote app state (parity with the TypeScript CLI), instead of only deserializing localgodaddy.toml{ valid, errors, warnings }: missing URL → error; missing proxy URL /INACTIVE→ warningsTest plan
cargo buildcargo test -- application::commands::tests::validatecargo clippy -- -D warningscargo fmt --check