Skip to content

Hide cancelled/non-visible domains by default in domain list#94

Merged
jpage-godaddy merged 1 commit into
rust-portfrom
exclude-cancelled-domains
Jul 11, 2026
Merged

Hide cancelled/non-visible domains by default in domain list#94
jpage-godaddy merged 1 commit into
rust-portfrom
exclude-cancelled-domains

Conversation

@jpage-godaddy

Copy link
Copy Markdown
Collaborator

Summary

  • gddy domain list now defaults to statusGroups=VISIBLE, hiding cancelled/confiscated/other non-visible domains instead of returning every status.
  • Added --show-hidden to opt back into the old "show everything" behavior.
  • --status is unchanged and still takes precedence over the default filter (e.g. --status CANCELLED still works).

Why

Cancelled domains were cluttering domain list output. The v1 API's statuses enum has ~150 granular values (many internal registry workflow states), so hardcoding "all statuses minus CANCELLED" would be brittle. Instead this uses the API's existing statusGroups=VISIBLE grouping, which is maintained server-side.

Test plan

  • cargo test domain::list — new wants_visible_only unit test + existing parse_statuses test pass
  • cargo clippy -- -D warnings — clean
  • cargo fmt --check — clean
  • cargo run -- domain list --help — confirmed updated help text and new --show-hidden flag render correctly

Default `domain list` to statusGroups=VISIBLE so cancelled/confiscated
domains no longer clutter the list. Add --show-hidden to opt back into
seeing everything; --status is unchanged and still takes precedence.
@jpage-godaddy jpage-godaddy requested a review from Copilot July 10, 2026 23:24
@jpage-godaddy jpage-godaddy changed the base branch from main to rust-port July 10, 2026 23:26
@jpage-godaddy

Copy link
Copy Markdown
Collaborator Author

Retargeting base branch to rust-port; reopening to trigger CI.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rust-based gddy CLI’s domain listing behavior to hide non-visible (e.g., cancelled/confiscated) domains by default via the API’s status_groups=VISIBLE, while also reflecting a much broader repository migration away from the prior TypeScript/Vitest toolchain into a Rust workspace with new modules, schemas, and CI/release automation.

Changes:

  • Adjust gddy domain list to default to VISIBLE status group filtering and add --show-hidden to opt back into the prior “show everything” behavior (while preserving --status precedence).
  • Introduce/expand Rust CLI modules (domain/webhook/payments/etc.), along with supporting macros/utilities (e.g., output schema + next-action helpers).
  • Remove TypeScript CLI implementation and test infrastructure; update CI and release automation for Rust.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vitest.config.ts Removed (TypeScript/Vitest toolchain cleanup as part of Rust migration).
tsconfig.json Removed (TypeScript configuration no longer applicable).
tests/unit/shared/cli-trace.test.ts Removed (TS unit tests removed with TS code).
tests/unit/services/public-url.test.ts Removed (TS unit tests removed with TS code).
tests/unit/fixtures.test.ts Removed (TS unit tests removed with TS code).
tests/unit/extension/bundler-config.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/SEC007-inspector.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/SEC006-module-patching.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/SEC004-process-internals.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/SEC003-vm.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC110-sensitive-ops.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC109-encoded-blob.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC108-external-url.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC107-inspector.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC106-module-patch.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC105-native-addon.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC104-process-binding.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC103-vm.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC102-child-process.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/rules/bundle/SEC101-eval.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/security/bundle-types.test.ts Removed (TS unit tests removed with TS code).
tests/unit/core/environment.test.ts Removed (TS unit tests removed with TS code).
tests/unit/cli/truncation.test.ts Removed (TS unit tests removed with TS code).
tests/unit/cli/deploy-stream.test.ts Removed (TS unit tests removed with TS code).
tests/unit/cli/api-command.test.ts Removed (TS unit tests removed with TS code).
tests/unit/cli/api-catalog.test.ts Removed (TS unit tests removed with TS code).
tests/unit/cli-registry.test.ts Removed (TS unit/integration harness removed with TS CLI).
tests/unit/auth.test.ts Removed (TS unit tests removed with TS code).
tests/setup/tui-mocks.ts Removed (TS test scaffolding removed).
tests/setup/test-utils.ts Removed (TS test scaffolding removed).
tests/setup/system-mocks.ts Removed (TS test scaffolding removed).
tests/setup/msw-server.ts Removed (MSW-based TS test server removed).
tests/setup/handlers/webhook-handlers.ts Removed (MSW handler removed).
tests/setup/global-setup.ts Removed (Vitest global setup removed).
tests/setup/fixtures/webhook-fixtures.ts Removed (TS fixtures removed).
tests/setup/fixtures/fixture-utils.ts Removed (TS fixtures removed).
tests/setup/fixtures/error-fixtures.ts Removed (TS fixtures removed).
tests/setup/fixtures/auth-fixtures.ts Removed (TS fixtures removed).
tests/setup/fixtures/application-fixtures.ts Removed (TS fixtures removed).
tests/setup/effect-test-utils.ts Removed (Effect TS test utilities removed).
tests/setup/auth-utils.ts Removed (TS auth test helpers removed).
tests/integration/webhook-service.test.ts Removed (TS integration tests removed).
tests/integration/auth-flow.test.ts Removed (TS integration tests removed).
tests/helpers/node-fs.ts Removed (TS helper removed).
tests/fixtures/malicious-bundle.mjs Removed (TS-era security test fixture removed).
tests/fixtures/extensions/with-local-tsconfig/tsconfig.json Removed (TS fixture removed).
tests/fixtures/extensions/with-local-tsconfig/src/index.ts Removed (TS fixture removed).
tests/fixtures/extensions/with-local-tsconfig/package.json Removed (TS fixture removed).
tests/fixtures/extensions/with-deps/src/index.ts Removed (TS fixture removed).
tests/fixtures/extensions/with-deps/package.json Removed (TS fixture removed).
tests/fixtures/extensions/simple-ts/src/index.ts Removed (TS fixture removed).
tests/fixtures/extensions/simple-ts/package.json Removed (TS fixture removed).
tests/fixtures/extensions/invalid-syntax/src/index.ts Removed (TS fixture removed).
tests/fixtures/extensions/invalid-syntax/package.json Removed (TS fixture removed).
tests/fixtures/clean-bundle.mjs Removed (TS-era security test fixture removed).
src/shared/cli-trace.ts Removed (TS implementation removed).
src/services/webhook-events.ts Removed (TS implementation removed).
src/services/public-url.ts Removed (TS implementation removed).
src/services/http-helpers.ts Removed (TS implementation removed).
src/services/extension/presigned-url.ts Removed (TS implementation removed).
src/index.ts Removed (TS entrypoint removed).
src/effect/services/keychain.ts Removed (TS Effect services removed).
src/effect/services/browser.ts Removed (TS Effect services removed).
src/effect/runtime.ts Removed (TS Effect runtime removed).
src/effect/layers/node-live.ts Removed (TS Effect layer removed).
src/effect/fs-utils.ts Removed (TS Effect utilities removed).
src/effect/errors.ts Removed (TS error types removed).
src/core/webhooks.ts Removed (TS core module removed).
src/core/security/types.ts Removed (TS security types removed).
src/core/security/rules/SEC010-sensitive-paths.ts Removed (TS security rules removed).
src/core/security/rules/SEC009-large-blobs.ts Removed (TS security rules removed).
src/core/security/rules/SEC008-external-urls.ts Removed (TS security rules removed).
src/core/security/rules/SEC007-inspector.ts Removed (TS security rules removed).
src/core/security/rules/SEC006-module-patching.ts Removed (TS security rules removed).
src/core/security/rules/SEC005-native-addons.ts Removed (TS security rules removed).
src/core/security/rules/SEC004-process-internals.ts Removed (TS security rules removed).
src/core/security/rules/SEC003-vm.ts Removed (TS security rules removed).
src/core/security/rules/SEC002-child-process.ts Removed (TS security rules removed).
src/core/security/rules/SEC001-eval.ts Removed (TS security rules removed).
src/core/security/rules/index.ts Removed (TS security rules index removed).
src/core/security/rules/bundle/SEC110-sensitive-ops.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC109-encoded-blob.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC108-external-url.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC107-inspector.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC106-module-patch.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC105-native-addon.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC104-process-binding.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC103-vm.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC102-child-process.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/SEC101-eval.ts Removed (TS bundle rules removed).
src/core/security/rules/bundle/index.ts Removed (TS bundle rules index removed).
src/core/security/file-discovery.ts Removed (TS security code removed).
src/core/security/engine.ts Removed (TS security code removed).
src/core/security/config.ts Removed (TS security config removed).
src/core/extension/validation.ts Removed (TS placeholder module removed).
src/core/extension/naming.ts Removed (TS naming utilities removed).
src/cli/services/cli-config.ts Removed (TS CLI config removed).
src/cli/schemas/api/registry.generated.ts Removed (TS generated registry removed).
src/cli/schemas/actions/index.ts Removed (TS schemas loader removed).
src/cli/index.ts Removed (TS CLI export surface removed).
src/cli/commands/webhook.ts Removed (TS webhook command removed).
src/cli/agent/types.ts Removed (TS agent envelope types removed).
src/cli/agent/truncation.ts Removed (TS truncation logic removed).
src/cli/agent/stream.ts Removed (TS streaming types removed).
rust/tools/generate-api-catalog/Cargo.toml Added (Rust tool for generating API catalog).
rust/src/webhook/mod.rs Added (Rust webhook module: gddy webhook events).
rust/src/payments/mod.rs Added (Rust payments module: gddy payments add).
rust/src/pat/guides/auth.md Added (Documentation for OAuth vs PAT auth in Rust CLI).
rust/src/output_schema.rs Added (Macro + support for output-schema declarations).
rust/src/next_action.rs Added (Helper to prefix next_actions with gddy).
rust/src/hosting/mod.rs Added (Rust hosting module entrypoint).
rust/src/domain/nameservers.rs Added (gddy domain nameservers set command + schema).
rust/src/domain/get.rs Added (gddy domain get command).
rust/src/domain/contacts.rs Added (Local-file domain contacts management).
rust/src/domain/agreements.rs Added (gddy domain agreements command).
rust/src/application/mod.rs Added (Rust application module entrypoint).
rust/scripts/regenerate-hosting-spec.sh Added (Script to refresh hosting spec + catalog).
rust/schemas/actions/manifest.json Added (Rust actions schema manifest).
rust/schemas/actions/commerce-payment-refund.json Added (Example action schema JSON).
rust/domains-client/scripts/regenerate-spec.sh Added (Script to regenerate domains OpenAPI spec).
rust/domains-client/Cargo.toml Added (Generated domains client crate definition).
rust/domains-client/build.rs Added (Build-time client generation from vendored spec).
rust/Cargo.toml Added (Rust workspace + main crate config).
rust/build.rs Added (Build metadata: commit/date env vars + rerun triggers).
require-shim.js Removed (TS build shim no longer used).
release-please-config.json Added (release-please config for Rust package).
package.json Removed (Node package removed).
mise.toml Updated (tooling now tracks Rust stable instead of Node).
build.mjs Removed (TS esbuild build script removed).
biome.json Removed (Biome config removed).
AGENTS.md Updated (agent/dev notes now describe Rust CLI patterns).
.release-please-manifest.json Added (release-please manifest for Rust version).
.nvmrc Removed (Node version pin removed).
.github/workflows/stale.yml Updated (pinned action SHA).
.github/workflows/release.yaml Removed (Node changesets release workflow removed).
.github/workflows/pr-title.yml Added (PR title conventional commit enforcement).
.github/workflows/codeql-analysis.yml Updated (CodeQL now targets Rust and builds via cargo).
.github/workflows/cicd.yml Updated (CI now runs Rust check/fmt/clippy/test and schema ref checks).
.changeset/README.md Updated (explains changesets are historical after Rust rewrite).
.agents/skills/godaddy-cli/SKILL.md Updated (docs updated for new godaddy api command structure).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jpage-godaddy jpage-godaddy merged commit ad17cd3 into rust-port Jul 11, 2026
2 checks passed
@jpage-godaddy jpage-godaddy deleted the exclude-cancelled-domains branch July 11, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants