Skip to content

[api] add await-wrap class for testing async-await#21

Merged
jcrugzz merged 4 commits intomasterfrom
async-await
Sep 20, 2018
Merged

[api] add await-wrap class for testing async-await#21
jcrugzz merged 4 commits intomasterfrom
async-await

Conversation

@jcrugzz
Copy link
Collaborator

@jcrugzz jcrugzz commented Sep 19, 2018

No description provided.

Copy link

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once CI passes with ✅

README.md Outdated
const cql = datastar.schema.cql;

// Wrap the model to expose async/await functions via `thenables`
const Model = new Wrap(datastar.define('model', {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new AwaitWrap ?

*
* @class Wrap
*/
class Wrap {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you name this AwaitWrap for consistency?

@jcrugzz jcrugzz merged commit 1358982 into master Sep 20, 2018
@jcrugzz jcrugzz deleted the async-await branch September 20, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants