eslint-config-godaddy: Mocha/JSON plugins

[gingur]

Are these plugins required? I'm using the second approach defined here using a .eslintrc file and I get an error about missing these dependencies. I'm not using mocha in my project (using ava), and I'm not linting any json files, so having these dependencies seem overkill.

[msluther]

I don't disagree, but there's some equilibrium between having a common configuration for use and either having 9001 different combinations of configurations or a minmal set and folks needing to add their own plugins ~80% of the time.

Perhaps we should re-evaluate what the common configuration should be, maybe it's shifted away from needing mocha/json and we should sever those dependencies.

I would probably also be okay in general with some more bare-bones versions of these configs for folks not in the 80% (or whatever % it happens to be) to start from. e.g. maybe we have a *-minimal for each of the common configs and the ones without the -minimal suffix keep the more "optional but common" dependencies.

[gingur]

Looking at the usage, we use 1 mocha related rule (out of 22), and 0? json rules out of 4?

I'm wondering if the extends array would be a better way to apply these. Something like { "extends": ["plugin:godaddy/mocha", "plugin:godaddy/json] }" which could optionally be added when defining a .eslintrc file (most common use case?)

[msluther]

I could see us doing something like that. I suspect that we might still want common sets of configuration though so people aren't needing to duplicate eslint configs across tons of packages.

As for the json rules, I suspect that when #88 went through we missed that it changes from the json plugin@1 to v2, which has real rules defined other than just "is it json" so that likely need to be fixed up here as well depending on what we decide to do.