Migrate to GH Actions #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxmarbles
requested review from
3rd-Eden,
DullReferenceException,
SivanMehta,
Swaagie,
indexzero,
jcrugzz,
kawikabader,
kinetifex,
mayank23,
msluther,
samshull and
silasbw
tarkatronic
approved these changes
Dec 17, 2020
msluther
reviewed
Dec 17, 2020
Merged
package.json
Outdated
| "version": "6.0.0", | ||
| "description": "The approach to JavaScript at GoDaddy. We think it's pretty decent.", | ||
| "scripts": { | ||
| "prepublishOnly": "npm test", |
There was a problem hiding this comment.
I'm not sure this will do much since we don't publish at the top level but instead on an individual package basis.
There was a problem hiding this comment.
Good callout. Is it possible for this to be placed in the sub-packages instead?
Contributor
There was a problem hiding this comment.
Can we do this in a separate PR?
Member
Author
There was a problem hiding this comment.
Fair enough I'll do a separate PR to script it out better for publishing and such
msluther
approved these changes
Dec 18, 2020
wcole1-godaddy
pushed a commit
that referenced
this pull request
Oct 13, 2025
* [dist] add workflow and update devDeps * [dist] clean up lock files of private registry * [tiny] add prepublishOnly for protection * [tiny] revert prepublish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.