Skip to content

Conversation

@Swaagie
Copy link
Member

@Swaagie Swaagie commented Apr 1, 2016

Update eslint and babel-eslint to fix the estraverse-fb dependency issue.
To pass our own styleguide/tests the 'use strict' was required.

This works for ES6 would like someone that still uses ES5 to confirm.

Also had to change "sourceType": "string" to "sourceType": "module" for the linting to work on es6 import styles at all. I think this is fine since we create mostly modular es6 modules anyways that are then later packed/bundled with builders.

@jcrugzz
Copy link

jcrugzz commented Apr 4, 2016

This LGTM 👍. Still passes on an es5 project

@indexzero
Copy link
Contributor

+1

@indexzero indexzero merged commit 4d37e9c into godaddy:master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants