Skip to content

turn ”react/prefer-es6-class" on as an error #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2017
Merged

turn ”react/prefer-es6-class" on as an error #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a522093
turn ”react/prefer-es6-class" on as a warning
yhan-godaddy Dec 29, 2016
843c6bb
turn it as an error
yhan-godaddy Jan 3, 2017
91bb450
es5 fix
yhan-godaddy Jan 3, 2017
d3a7f86
Merge branch 'master' into yhan/add-prefer-es6-class
indexzero Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dotfiles/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
"react/display-name": 0,
"react/jsx-uses-react": 1,
"react/jsx-pascal-case": 2,
"react/prefer-es6-class": 2,
"semi": 1,
"strict": [2, "global"],
"use-isnan": 2,
Expand Down
3 changes: 2 additions & 1 deletion es5/fix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ var es5Options = {
sourceType: 'script'
},
rules: {
'react/display-name': 2
'react/display-name': 2,
"react/prefer-es6-class": 0,
Copy link
Contributor Author

@yhan64 yhan64 Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpaulucci Does this work?

Copy link

@mpaulucci mpaulucci Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should! 👍

}
}
};
Expand Down