adds react-flow package #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samshull
reviewed
Jul 19, 2017
| ``` js | ||
| { | ||
| "scripts": { | ||
| "lint": eslint-godaddy-flow files/ you/ want-to/ lint/" |
Contributor
There was a problem hiding this comment.
Unclosed string in markdown
samshull
reviewed
Jul 19, 2017
| ``` js | ||
| { | ||
| "scripts": { | ||
| "lint": eslint-godaddy-react-flow files/ you/ want-to/ lint/" |
josephjunker
force-pushed
the
add-flow-configs
branch
from
d385b3b to
5089fcc
Compare
josephjunker
changed the title
added 2 commits
July 19, 2017 14:34
josephjunker
force-pushed
the
add-flow-configs
branch
from
0489f11 to
fb356ba
Compare
samshull
approved these changes
Jul 19, 2017
|
Give this a couple days to marinate. I know @indexzero wants a chance to review |
indexzero
suggested changes
Jul 24, 2017
Contributor
indexzero
left a comment
indexzero
left a comment
There was a problem hiding this comment.
Overall +1, but would like to see the ruleset inherit from eslint-config-godaddy-react so new react-specific (but not flow-specific) changes can be made in only one place.
| @@ -0,0 +1,39 @@ | |||
| module.exports = { | |||
| extends: [ | |||
| require('./extends')('eslint-config-godaddy'), | |||
Contributor
There was a problem hiding this comment.
Why wouldn't this be eslint-config-godaddy-react?
require('./extends')('eslint-config-godaddy-react'),
Contributor
Author
There was a problem hiding this comment.
Makes sense, I'll make this change.
| 'react/jsx-curly-spacing': [2, 'always', { | ||
| spacing: { objectLiterals: 'never' } | ||
| }], | ||
| 'jsx-quotes': [2, 'prefer-single'], |
Contributor
There was a problem hiding this comment.
All of these rules should be inherited from eslint-config-godaddy-react no? If we add rules to that package I'd like to see them reflected here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some teams are adopting Flow, but additional configuration is needed to get eslint to work with it.