Reintroducing react deprecated lint rule #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusave
force-pushed
the
react-deprecated-rule
branch
from
c9e4e70 to
10c950a
Compare
msluther
approved these changes
Mar 13, 2019
Contributor
msluther
left a comment
msluther
left a comment
There was a problem hiding this comment.
Assuming this gets published as a breaking change.
burgessa23
approved these changes
Mar 14, 2019
indexzero
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there has been sufficient time to upgrade to the new react lifecycle methods, we should reintroduce the rule (reverting #65)