Reducing react/no-deprecated lint rule to a warning #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxmarbles
approved these changes
May 15, 2018
indexzero
approved these changes
May 16, 2018
bcbailey
approved these changes
May 17, 2018
burgessa23
approved these changes
May 17, 2018
msluther
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
react@16.3has marked certain functions (componentWillReceiveProps,componentWillMount, etc.) as deprecated, there is a new lint rule in place that causes errors to be thrown when linting. To give developers time to refactor these cases and prevent the introduction ofeslint-disablerepeatedly, reducing the severity of this rule to a warning seems to be a good corse of action.