Skip to content

Require an Error object when rejecting a promise #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Require an Error object when rejecting a promise #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b2cb29
Require an Error object when rejecting a promise
fabiomcosta Jun 19, 2019
7efc80b
reverting lock changes
fabiomcosta Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/eslint-config-godaddy/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ module.exports = {
'no-shadow': 1,
'no-sparse-arrays': 2,
'no-sync': 2,
'no-throw-literal': 1,
'no-throw-literal': 2,
'no-undef-init': 2,
'no-undefined': 2,
'no-underscore-dangle': 0,
Expand All @@ -112,6 +112,7 @@ module.exports = {
'strict': [2, 'global'],
'use-isnan': 2,
'valid-jsdoc': [2, { prefer: { return: 'returns' }, requireReturn: false }],
'prefer-promise-reject-errors': 2,
Copy link
Contributor

@gingur gingur Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest relaxing this new rule by adding allowEmptyReject: true to allow Promise.reject() to still work, but Promise.reject("no") to error

Copy link
Contributor

@gingur gingur Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, after thinking about it a bit more, disregard. the following code would still produce a catch w/ undefined which I would not want. so even Promise.reject should always be called with an error object.

async function example() {
  return Promise.reject();
}
(async () => {
  try {
  	const res = await example();
  } catch (e) {
    console.log('err', e); // undefined
  }
})();

//
// Whitespace or other stylistic rules. No --fix option exists in eslint,
// but previously existed in jscs
Expand Down