This repository was archived by the owner on May 29, 2025. It is now read-only.
[fix] reset slug counts before rendering to prevent inconsistent anchors#9
Merged
clinejm merged 4 commits intogodaddy:masterfrom Aug 6, 2018
Merged
[fix] reset slug counts before rendering to prevent inconsistent anchors#9clinejm merged 4 commits intogodaddy:masterfrom
clinejm merged 4 commits intogodaddy:masterfrom
Conversation
QuicheSama
commented
Aug 3, 2018
| tree.update(); | ||
|
|
||
| assume(tree.find('#header-2')).to.have.length(0); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
I may be misunderstanding the test, but I am fairly certain this should replicate the issue. Any ideas @clinejm @dustinsavery
QuicheSama
changed the title
dusave
approved these changes
Aug 6, 2018
clinejm
approved these changes
Aug 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that re-rendering the component causes header anchor tags to be incremented. This should not happen as anchor tags should be consistent.