feat(splitio-api-wrapper): implement httpGet function#3
Merged
celiawaggoner merged 4 commits intomasterfrom Dec 11, 2019
Merged
feat(splitio-api-wrapper): implement httpGet function#3celiawaggoner merged 4 commits intomasterfrom
celiawaggoner merged 4 commits intomasterfrom
Conversation
rohanmurthy
approved these changes
Dec 10, 2019
jh2oman
approved these changes
Dec 10, 2019
silasbw
suggested changes
Dec 10, 2019
silasbw
reviewed
Dec 10, 2019
lib/splitio-api-binding.js
Outdated
| try { | ||
| const response = await axios(requestOptions) | ||
| return response.data | ||
| } catch (e) { |
Contributor
There was a problem hiding this comment.
In general i like the idea of catching the error and wrapping it so that the httpGet API doesn't leak details about it's implementation (e.g., using axios). on the other hand, i can imagine callers wanting more information about the failure (e.g., http code). so, we should either be prepared to add a bunch of metadata to the exception, or just let the axios one get thrown.
naming nit: e -> err
silasbw
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.