Add details on the shader's eye position built-ins #11323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed descriptions for CAMERA_POSITION_WORLD and EYE_OFFSET to benefit XR developers. I decided to make this pull request because my dad spent a while trying to get the eye positions correct, eventually finding that CAMERA_POSITION_WORLD is the same for both eyes, and later that the EYE_OFFSET is not in world space. My dad and I were almost led to believe that the perspective artifacts we saw with our custom shader were due to an optimization in the headset, and that we would have to work around it in our game, but it has since been fixed.
Calinou
added
enhancement
area:manual
mhilbrunner
approved these changes
Sep 26, 2025
|
Thank you! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed descriptions for CAMERA_POSITION_WORLD and EYE_OFFSET to benefit XR developers.