Skip to content

Conversation

@Piralein
Copy link
Member

@Piralein Piralein commented Jan 11, 2023

Add partial to all classes derived from Godot.Object.
Add using Godot and using System for consistency across all examples, in this order.
Remove Godot.* Namespace for signals.rst.
Remove unneedet indentation in scenes_versus_scripts.rst.
Change RigidBody to RigidBody3D in rigid_body.rst
Change codetab identifier from none C# to csharp in inspector_plugins.rst

(I left the Godot.Object in c_sharp_features.rst, because it it referenced inside the text above)

The "Your first 3D game" is not included, because of the big refactor PR of it.

@YuriSizov YuriSizov added bug topic:dotnet area:getting started Issues and PRs related to the Getting Started section of the documentation area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jan 11, 2023
@YuriSizov YuriSizov requested a review from raulsntos January 11, 2023 20:17
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge, thank you very much for taking the time to work on this! ❤️

We should consider removing the using System since I don't think any of the examples actually use anything from System, and if we enable ImplicitUsings in the future it won't be necessary anyway.

I also noticed we are inconsistent with the class names in examples (e.g.: Sprite : Sprite3D, Node2D : Godot.Node2D, YourClassName : MultiMeshInstance3D). Not necessarily in this PR but in the future I think it'd be nice to be more consistent with the names, for example using the format My{{BASE_CLASS}} : {{BASE_CLASS}}.

@Piralein Piralein force-pushed the partial branch 2 times, most recently from f17b236 to 1ce2717 Compare January 12, 2023 17:30
@YuriSizov YuriSizov changed the title update c# class examples Update C# code samples in Getting Started and Tutorials Jan 13, 2023
@YuriSizov YuriSizov merged commit a20c7f4 into godotengine:master Jan 13, 2023
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:getting started Issues and PRs related to the Getting Started section of the documentation area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants