-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update C# code samples in Getting Started and Tutorials #6581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "partial\u{1F511}"
Conversation
raulsntos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge, thank you very much for taking the time to work on this! ❤️
We should consider removing the using System since I don't think any of the examples actually use anything from System, and if we enable ImplicitUsings in the future it won't be necessary anyway.
I also noticed we are inconsistent with the class names in examples (e.g.: Sprite : Sprite3D, Node2D : Godot.Node2D, YourClassName : MultiMeshInstance3D). Not necessarily in this PR but in the future I think it'd be nice to be more consistent with the names, for example using the format My{{BASE_CLASS}} : {{BASE_CLASS}}.
f17b236 to
1ce2717
Compare
|
Thanks! |
Add
partialto all classes derived from Godot.Object.Add
using Godotandusing Systemfor consistency across all examples, in this order.Remove
Godot.*Namespace forsignals.rst.Remove unneedet indentation in
scenes_versus_scripts.rst.Change
RigidBodytoRigidBody3Dinrigid_body.rstChange codetab identifier from
none C#tocsharpininspector_plugins.rst(I left the
Godot.Objectinc_sharp_features.rst, because it it referenced inside the text above)The "Your first 3D game" is not included, because of the big refactor PR of it.