Replace text about migrating preprocessor directives with a short list of supported macros #7007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting macros with a short list of supported macros
mhilbrunner
added
enhancement
topic:rendering
area:manual
Member
|
I would probably shorten the text to simply mention that Godot has a shader preprocessor and then point to the actual preprocessor documentation (https://docs.godotengine.org/en/latest/tutorials/shaders/shader_reference/shader_preprocessor.html). This way we only have maintain one page when adding or changing preprocessor features. |
clayjohn
approved these changes
Jun 2, 2023
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
I think it is fine as-is. The full preprocessor doc is pretty large and doesn't quickly provide the information that is needed by this doc
mhilbrunner
approved these changes
Jun 2, 2023
Member
|
Thank you and congrats on your first merged contribution to Godot's documentation! 🎉 |
mhilbrunner
added a commit
to mhilbrunner/godot-docs
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7006.
This pull request deletes the text about migrating preprocessor directives, and replaces it with a grouped list of preprocessor directives (define, if, include, and pragma).