Update one-click bar appearance (remote debug icon) #7264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddy-exe
added
bug
area:getting started
paddy-exe
reviewed
May 2, 2023
Contributor
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
Looks good to me. However I think we switched to .webp files for images now so this might be a good option now to switch this image as well.
Contributor
Author
|
I did a few tries and I couldn't get a good lossless webp image that was smaller than the png. What tools would you recommend for format change + size optimization (I already tried cwebp)? |
Contributor
From the docs: https://docs.godotengine.org/en/stable/contributing/documentation/docs_image_guidelines.html |
One-click deploy used to show an Android icon, when available. Nowadays, remote debug (aka one-click deploy) for web and Android found under the same submenu in the top right buttons. Show the new icon with the submenu open instead. Image has been lightly edited from a 4.0.X screenshot to avoid distracting elements. New image sent in .webp format. No other references to the old image found on docs. Fixes godotengine#7226
Contributor
Author
|
|
paddy-exe
approved these changes
May 2, 2023
mhilbrunner
approved these changes
May 2, 2023
Member
|
Thank you! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-click deploy used to show an Android icon, when available. Nowadays, remote debug (aka one-click deploy) for web and Android found under the same submenu in the top right buttons.
Show the new icon with the submenu open instead.
Image has been lightly edited from a 4.0.X screenshot to avoid distracting elements.
Fixes #7226