Skip to content

Conversation

@smix8
Copy link
Contributor

@smix8 smix8 commented May 18, 2023

Fixes wrong navigation agent example code.

Kinda silly that the NavigationAgent example code had multiple C++ examples in the GDScript section for months that I copied from the source code when drafting the documentation the first time. Now while updating I drafted again with C++ source code and forgot to change.

Not a single user complain and now it was even changed again with the pr today without fixing it and it passed the pr review.

Every single person involved should pour some ash on their head, including me.

Fixes wrong navigation agent example code.
@smix8 smix8 force-pushed the fix_navagent_example_4.x branch from aebe50b to 9f4ef23 Compare May 18, 2023 19:25
@mhilbrunner mhilbrunner added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels May 18, 2023
@mhilbrunner mhilbrunner merged commit 1c64c4a into godotengine:master May 18, 2023
@mhilbrunner
Copy link
Member

Thanks! Does this need a separate PR for 4.0?

@smix8
Copy link
Contributor Author

smix8 commented May 18, 2023

@mhilbrunner
Yes, cause in Godot 4.0 the agent_set_avoidance_callback() function is named agent_set_callback() and agent_set_use_3d_avoidance() does not exist.

@smix8 smix8 deleted the fix_navagent_example_4.x branch May 18, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants