Mentioning the GDExtension icon support #7461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddy-exe
added
the
area:manual
paddy-exe
requested changes
Jun 6, 2023
Contributor
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
Thanks for your PR! I reworked the sentence structure to clarify a few things and shorten it the important bits. Furthermore, the path should point to a 16 by 16 px image so the icon is scaled properly so I emphasized this. I hope you can agree with my suggestions :)
A node that is loaded through GDExtension can have a custom icon. Icon's path can be added via the `gdextension` file. (See godotengine/godot#75472). Commit makes a mention of this in the C++ tutorial.
paddy-exe
approved these changes
Jun 8, 2023
Contributor
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the quick updates!
mhilbrunner
approved these changes
Jul 18, 2023
Member
|
Thanks for contributing and congrats on your first merged PR to Godot's docs! Sorry this took a bit to get merged as I was a bit busy due to real life events and the Valencia sprint :) |
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node that is loaded through GDExtension can have a custom icon. Icon's path can be added via the
gdextensionfile. (See godotengine/godot#75472).Commit makes a mention of this in the C++ tutorial.